chore: bump ibctest version and ibc-go version to v6 for e2e module #2479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin-axner
commented
Oct 5, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2479 +/- ##
=======================================
Coverage 78.65% 78.65%
=======================================
Files 178 178
Lines 12367 12367
=======================================
Hits 9727 9727
Misses 2208 2208
Partials 432 432
|
colin-axner
commented
Oct 5, 2022
| "go.uber.org/zap" | ||
|
|
||
| "github.com/cosmos/ibc-go/e2e/testconfig" | ||
| ) | ||
|
|
||
| const ( | ||
| cosmosRelayerRepository = "ghcr.io/cosmos/relayer" | ||
| cosmosRelayerUser = "100:1000" // docker run -it --rm --entrypoint echo ghcr.io/cosmos/relayer "$(id -u):$(id -g)" |
There was a problem hiding this comment.
Maybe this should be a const in ibctest.
There was a problem hiding this comment.
nice suggestion, opened an issue strangelove-ventures/interchaintest#321
Comment on lines
+21
to
+28
| // Options are used to allow for relayer version selection and specifying the default processing option. | ||
| func newCosmosRelayer(t *testing.T, tc testconfig.TestConfig, logger *zap.Logger, dockerClient *dockerclient.Client, network string) ibc.Relayer { | ||
| return ibctest.NewBuiltinRelayerFactory(ibc.CosmosRly, logger, relayer.CustomDockerImage(cosmosRelayerRepository, tc.RlyTag), relayer.StartupFlags("-p", "events")).Build( | ||
| customImageOption := relayer.CustomDockerImage(cosmosRelayerRepository, tc.RlyTag, cosmosRelayerUser) | ||
| relayerProcessingOption := relayer.StartupFlags("-p", "events") // relayer processes via events | ||
|
|
||
| relayerFactory := ibctest.NewBuiltinRelayerFactory(ibc.CosmosRly, logger, customImageOption, relayerProcessingOption) | ||
|
|
||
| return relayerFactory.Build( |
There was a problem hiding this comment.
decided to breakup this function a little to increase readability
colin-axner
requested review from
AdityaSripal,
crodriguezvega,
seantking,
charleenfei,
damiannolan and
chatton
as code owners
damiannolan
approved these changes
Oct 5, 2022
| "go.uber.org/zap" | ||
|
|
||
| "github.com/cosmos/ibc-go/e2e/testconfig" | ||
| ) | ||
|
|
||
| const ( | ||
| cosmosRelayerRepository = "ghcr.io/cosmos/relayer" | ||
| cosmosRelayerUser = "100:1000" // docker run -it --rm --entrypoint echo ghcr.io/cosmos/relayer "$(id -u):$(id -g)" |
There was a problem hiding this comment.
Maybe this should be a const in ibctest.
crodriguezvega
approved these changes
Oct 6, 2022
9 tasks
mergify bot
pushed a commit
that referenced
this pull request
Nov 11, 2022
…2479) ## Description closes: #XXXX --- Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why. - [ ] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work. - [ ] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md). - [ ] Wrote unit and integration [tests](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#testing) - [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`) - [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code). - [ ] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md` - [ ] Re-reviewed `Files changed` in the Github PR explorer - [ ] Review `Codecov Report` in the comment section below once CI passes (cherry picked from commit 4bd05c6) # Conflicts: # e2e/go.mod # e2e/go.sum # e2e/testconfig/testconfig.go # e2e/tests/core/client_test.go # e2e/tests/interchain_accounts/base_test.go # e2e/tests/interchain_accounts/incentivized_test.go # e2e/tests/transfer/base_test.go # e2e/tests/transfer/incentivized_test.go # e2e/tests/upgrades/upgrade_test.go # e2e/testsuite/grpc_query.go # e2e/testsuite/relayer.go # e2e/testsuite/testsuite.go
crodriguezvega
added a commit
that referenced
this pull request
Nov 11, 2022
…backport #2479) (#2729) * chore: bump ibctest version and ibc-go version to v6 for e2e module (#2479) ## Description closes: #XXXX --- Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why. - [ ] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work. - [ ] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md). - [ ] Wrote unit and integration [tests](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#testing) - [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`) - [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code). - [ ] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md` - [ ] Re-reviewed `Files changed` in the Github PR explorer - [ ] Review `Codecov Report` in the comment section below once CI passes (cherry picked from commit 4bd05c6) # Conflicts: # e2e/go.mod # e2e/go.sum # e2e/testconfig/testconfig.go # e2e/tests/core/client_test.go # e2e/tests/interchain_accounts/base_test.go # e2e/tests/interchain_accounts/incentivized_test.go # e2e/tests/transfer/base_test.go # e2e/tests/transfer/incentivized_test.go # e2e/tests/upgrades/upgrade_test.go # e2e/testsuite/grpc_query.go # e2e/testsuite/relayer.go # e2e/testsuite/testsuite.go * fix conflicts Co-authored-by: colin axnér <[email protected]> Co-authored-by: Carlos Rodriguez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes